This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Breaking: Update JSX tagName conversion for TS 2 (refs #105) #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
This was referenced Oct 24, 2016
Closed
|
Want to rebase so we can see if the tests pass now that #107 is merged? |
JamesHenry
force-pushed
the
jsx-tag-names-as-expressions
branch
from
bb328fa to
42f234c
Compare
|
LGTM |
|
Done! 🎉 |
JamesHenry
added a commit
that referenced
this pull request
Nov 5, 2016
nzakas
pushed a commit
that referenced
this pull request
Nov 8, 2016
* Breaking: Updated TypeScript peerDependency to ^2.0.3 (refs #105) * Chore: Added test for shorthand-ambient-module-declaration (refs #105) (#109) * Chore: Added test for non-null assertion operator (refs #105) (#110) * Breaking: Update JSX tagName conversion for TS 2 (refs #105) (#108) * Chore: Added test for typed this parameter (fixes #105) * Fix: Add parameter type annotations to the AST (refs #105) (#111)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In microsoft/TypeScript#7645, TypeScript changed the way it handles JSX tag names.
This PR updates our conversion process accordingly, and adds a couple of helper functions for checking JSX nodes.
This PR is into the
ts-2branch, which is where all of the breaking changes will go, along with the updated TSpeerDependency.I will submit a final PR from
ts-2to master, once all the necessary updates are merged.NOTE: The tests will fail on
ts-2work until #107 is merged